[openstreetmap/openstreetmap-website] Show tel: links on multiple phone numbers separated by ; (#2071)

krubokrubo notifications at github.com
Sat Nov 24 19:34:05 UTC 2018


I actually implemented the feature for multiple phone numbers in afbb28aa.  This increased [`browse_helper.rb`](https://github.com/krubokrubo/openstreetmap-website/blob/afbb28aa11f5e59f61b464ccb095122595b235c1/app/helpers/browse_helper.rb) by 8 lines of code.

Unfortunately this raised a rubocop offense for ModuleLength.  So I made the current commit, 52694d23, to split [`browse_helper.rb`](https://github.com/krubokrubo/openstreetmap-website/blob/52694d23f38ef2a586c14a11badac8f992dd80ec/app/helpers/browse_helper.rb) and a new file, [`format_links_helper.rb`](https://github.com/krubokrubo/openstreetmap-website/blob/52694d23f38ef2a586c14a11badac8f992dd80ec/app/helpers/format_links_helper.rb).  Now rubocop doesn't find any offense, but please check if this is an appropriate way to do it.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2071

-- Commit Summary --

  * Show tel: links even when there are multiple phone numbers separated by ;
  * Split browse_helper.rb into two modules due to rubocop ModuleLength

-- File Changes --

    M .rubocop_todo.yml (1)
    M app/helpers/browse_helper.rb (115)
    A app/helpers/format_links_helper.rb (135)
    M test/helpers/browse_helper_test.rb (216)
    A test/helpers/format_links_helper_test.rb (261)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2071.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2071.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2071
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181124/c0ae5228/attachment-0001.html>


More information about the rails-dev mailing list