[openstreetmap/openstreetmap-website] Show tel: links on multiple phone numbers separated by ; (#2071)

Tom Hughes notifications at github.com
Sun Nov 25 14:13:53 UTC 2018


This is really hard to review because you seem to have made a lot of non-essential changes to the tests.

It would probably have been better to leave the existing tests (bar the changes needed to adapt to the API change) and add new tests for the semicolon separated lists to the end so that comparison tools are able to show the changes more clearly.

I think I'm right in saying that the only function change is that `/` is no longer allowed in numbers? Why did you choose to do that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2071#issuecomment-441443519
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181125/88df8d1f/attachment.html>


More information about the rails-dev mailing list