[openstreetmap/openstreetmap-website] Show tel: links on multiple phone numbers separated by ; (#2071)
notifications at github.com
Sun Nov 25 20:23:54 UTC 2018
Thanks for the feedback. After looking at the usage of the / in existing data, I think it was premature for me to disallow it from links.
It looks like the documented standard ((https://www.itu.int/rec/T-REC-E.123-200102-I/en), (http://publications.europa.eu/code/en/en-390300.htm), (https://tools.ietf.org/html/rfc3966#section-3)) is to use the / to separate alternative phone numbers without repeating the beginning part that is the same. In this case, the existing code which passes the / directly into the tel: URL would be incorrect. However, in the existing data, the / is widely used in a few countries (Germany, Austria, Hungary, Romania) to separate the region code from the local number. In this case, what the existing code does may be correct. It would be better to get feedback from someone in one of these countries before changing this.
So I think I'd better change this to keep the existing treatment of the /. I'll submit a new pull request to hopefully make things cleaner.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev