[openstreetmap/openstreetmap-website] Show tel: links for multiple phone numbers separated by ; (#2072)
notifications at github.com
Tue Nov 27 02:20:22 UTC 2018
This is the feature for multiple phone numbers (#2069) again. I'm now following the existing code in accepting the / symbol in phone number links. I also adjusted the tests so the comparison is clean.
(Note: I'm submitting this as a new PR so that the commit history is cleaner than my first try (#2071). github won't let me reopen the same PR since I force-pushed to the same branch.)
The feature is now implemented in 5ba64efd, which led to rubocop offenses that I resolved in d44ae2ef and 4826a6e3. Let me know if this is suitable.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* Show tel: links for multiple phone numbers separated by ;
* Fix AssignmentInCondition rubocop offenses in browse_helper.rb
* Split browse_helper.rb into two modules due to rubocop ModuleLength
-- File Changes --
M .rubocop_todo.yml (1)
M app/helpers/browse_helper.rb (115)
A app/helpers/format_links_helper.rb (138)
M test/helpers/browse_helper_test.rb (216)
A test/helpers/format_links_helper_test.rb (263)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev