[openstreetmap/openstreetmap-website] Show tel: links for multiple phone numbers separated by ; (#2072)

Tom Hughes notifications at github.com
Tue Nov 27 18:58:08 UTC 2018

What was the logic behind "fixing" the `AssignmentInCondition` offenses? It doesn't look like that would have triggered at the point so I'm guessing the issue was that moving them to the new helper would cause them to start triggering unless you excluded that?

For the record the reason I never fixed that is that I didn't see it as a major problem and I find the result extremely ugly :-(

That said there are a number of other places where I have similar feelings but have given in and held my nose and let rubocop have it's way so maybe we should do the same here - either that or just decide we don't like that rule and disable it globally.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181127/c9452c5e/attachment.html>

More information about the rails-dev mailing list