[openstreetmap/openstreetmap-website] Show tel: links for multiple phone numbers separated by ; (#2072)

Tom Hughes notifications at github.com
Tue Nov 27 19:01:13 UTC 2018


tomhughes requested changes on this pull request.



> @@ -0,0 +1,138 @@
+require "cgi"
+
+module FormatLinksHelper

If we're going to split this (the alternative being to just increase the limit as we've never worried about the rubocop length limits much) then I thing something like `BrowseTagsHelper` would be better given these helper methods are about dealing with formatting tag keys and values for the data browser rather than more general link formatting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2072#pullrequestreview-178954757
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181127/41d2cccc/attachment-0001.html>


More information about the rails-dev mailing list