[openstreetmap/openstreetmap-website] Show tel: links for multiple phone numbers separated by ; (#2072)

krubokrubo notifications at github.com
Wed Nov 28 03:53:13 UTC 2018


krubokrubo commented on this pull request.



> @@ -0,0 +1,138 @@
+require "cgi"
+
+module FormatLinksHelper

Sounds good, this is renamed now.

I'm fairly new to Ruby and rubocop, so I don't yet have an opinion about the rubocop rules, I was just trying to resolve the cascade of offenses. (First I got ModuleLength, then when I split the module it led to AssignmentInCondition, although I realize I made this unclear by committing the fixes in reverse order.)

If you're not concerned about those offenses, I'm happy to leave them as they were.  In that case, we could just look at commit 5ba64ef for this feature.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2072#discussion_r236933214
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181128/50f12f22/attachment.html>


More information about the rails-dev mailing list