[openstreetmap/openstreetmap-website] There should be space between paragraphs in changeset comment display (#2022)

[Nutchanon Wetchasit]

I have originally sparsely used OpenStreetMap's changeset comment feature. But few days ago, I have a run-in with commercial OSM (armchair) mapper which prompted me to leave a many-paragraph long comment explaining how exactly the changed features mismatched what's in the field.

But once I submitted the comments, OpenStreetMap.org's changeset discussion interface **simply shown my comments as big jumbles of text**, with no distinction where each paragraph started or ended; ended up making them very difficult to read and interpret:

* [The changeset discussion in question](https://www.openstreetmap.org/changeset/62658038)
* [Changeset discussion screenshot](https://u.cubeupload.com/xwindows/35JxYd.png)

A quick view of the page with CSS turned off revealed that HTML `<p>` paragraphs are indeed intact (and the thread became much more readable). This shows that CSS is the culprit:

* [Changeset discussion screenshot (with CSS turned off)](https://u.cubeupload.com/xwindows/8ZUCL5.png)

According to _Inspect_ tool on my browser, the problem rooted from the first ruleset at the beginning of [`screen-ltr-*.css`](https://www.openstreetmap.org/assets/screen-ltr-f0481d92f08111394761c5e32410e85988b21dda874cd0fbf9846e9f62f5cd86.css), which disables margin of paragraph tags with nothing else to re-enable it:

* [Screenshot of Inspect tool on changeset discussion](https://u.cubeupload.com/xwindows/woCv6R.png)
* [Screenshot of Inspect tool when the `margin: 0px` rule is temporarily disabled](https://u.cubeupload.com/xwindows/QDus7V.png); you would see that the paragraph spacing now appears, though with some side effects on the top bar.
* [Screenshot of changeset discussion when the `margin: 0px` rule is temporarily disabled](https://u.cubeupload.com/xwindows/8a1iBu.png); you would see that the comment is now much easier to read.

A solution could be creating a separate ruleset that specially targets `<p>` tag inside a block with `changeset-comments` class; then add `margin-bottom` style with appropriate size to it, maybe with `!important` override too.

Please investigate and fix; the changeset discussion is likely to become much more conductive if this is fixed.

Browser: Pale Moon 25.8.1 (GNU/Linux 32-bit)

**Notes:**

* While I'm not sure if this also affect note comments or not (since I don't leave a very long comment on notes), **a look on _Inspector_ tool strongly suggests that it is also the case**. The fix would be the same (but its parent block was marked with `note-comments` class rather than `changeset-comments` class).
* This bug does not affect the notification emails; the changeset comments look fine and readable there.
* This is not browser-specific, the lack of paragraph spacing is also reproducible on Opera 11.64 (Win32).
* If I remembered correctly, this bug exists since the first time I used OpenStreetMap's changeset discussion feature [on 21-Feb-2018](https://www.openstreetmap.org/changeset/56374444).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/2022
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181009/a5c1197a/attachment-0001.html>