[openstreetmap/openstreetmap-website] Don't duplicate note comments in RSS feeds for new notes (#2029)

[Rory McCann]

AFAIK this doesn't change the notes API? If you were doing something with notes, surely you'd use that rather than parsing the HTML in this? (if you are parsing the HTML then you're doing it wrong and shouldn't complain if this changes (IMO)) 

On 21 October 2018 20:44:19 CEST, Tom Hughes <notifications at github.com> wrote:
>Granted this is redundant but you could equally argue that it's always
>redundant to include the recent comment because it's in the full note.
>
>As it stands this would for example break any downstream user of the
>feed that chose just to ignore the comment and always show the full
>version of the note so it seems to be to be quite a risky change to
>make?

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431694354
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181021/f0c3ead2/attachment-0001.html>