[openstreetmap/openstreetmap-website] Don't duplicate note comments in RSS feeds for new notes (#2029)

Tom Hughes notifications at github.com
Sun Oct 21 20:40:06 UTC 2018


I confess that I don't really understand the notes feed, and I'm not sure who uses it and what for so I'm finding it hard to evaluate this.

The core problem is that it's a feed of notes but it is triggered by comments so that notes reappear when they have a new comment right? But it has this weird dual thing of showing both the latest comment (that caused it to be included) and the whole thread?

But it seems to me that you change doesn't really fix that because we still get the duplication the second time round - why is it a problem for a new note and not for subsequent comments?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2029#issuecomment-431702156
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20181021/dc112475/attachment.html>


More information about the rails-dev mailing list