[openstreetmap/openstreetmap-website] [Discussion] Refactors from RFG 2018 (#1918)

Andy Allan notifications at github.com
Mon Sep 10 01:42:15 UTC 2018


There's was a lot of fixup commits, and branch merges seem to have confused either me or github or both. So I've gone through all the commits to make a summary of what different topics were covered in here:

- [ ]  Refactor api methods into their own namespaced controllers (e.g. app/controllers/api/nodes_controller.rb)
- [ ]  Rubocop numeric predicates (foo < 0  becomes foo.negative?)
- [ ]  Resourceful naming for nodes_controller
- [ ]  Rubocop if/unless modifier
- [ ]  Rename usercontroller to userscontroller
- [ ]  Resourceful naming for userscontroller
- [ ]  Rubocop safe navigation
- [ ]  Rubocop assignment in condition
- [ ]  Rubocop ambiguous regexp literal
- [ ]  Rubocop shadowingouterlocalvariable
- [ ]  Rubocop ambiguous operator
- [ ]  Guard against undefined CSP_ENFORCE constant

I plan to work through this list, split some straightforward things off into their own PRs and then see what we're left with!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1918#issuecomment-419763898
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20180909/c09c2322/attachment.html>


More information about the rails-dev mailing list