[openstreetmap/openstreetmap-website] Eslint (#2209)

Tom Hughes notifications at github.com
Sun Apr 14 18:53:17 UTC 2019

Sadly while `eslint-rails-ee` is better than the original `eslint-rails` it turns out that the version of `eslint` it is bundling is still ancient and I'd really like to use something newer.

So this PR tries a new approach, installing eslint directly with yarn and then using a simple rake task to invoke it.

I chose to use yarn rather than npm simply because that is the preferred tool for managing javascript dependencies in rails although it does make it a bit more of a pain for people to setup.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Replace eslint-rails-ee with direct calls to eslint
  * Fix new eslint warnings

-- File Changes --

    M .gitignore (1)
    M .travis.yml (3)
    M Gemfile (3)
    M Gemfile.lock (13)
    M app/assets/javascripts/leaflet.zoom.js (102)
    M app/assets/javascripts/router.js (4)
    A lib/tasks/eslint.rake (27)
    A package.json (9)
    A yarn.lock (769)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190414/076af635/attachment.html>

More information about the rails-dev mailing list