[openstreetmap/openstreetmap-website] Supporting multiple API versions (#2353)

Andy Allan notifications at github.com
Fri Aug 30 11:09:19 UTC 2019


gravitystorm commented on this pull request.



> @@ -1,24 +1,58 @@
 OpenStreetMap::Application.routes.draw do
+  # Our api versions are decimals, but controllers cannot start with a number
+  # or contain punctuation
+  def v_string(version)
+    "v#{version.delete('.')}"

As discussed in the comments, semver would only use major version numbers here. So e.g. `v7` or `v124`. But it's a great point to raise, thank you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2353#discussion_r319465393
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190830/fec20f6b/attachment.html>


More information about the rails-dev mailing list