[openstreetmap/openstreetmap-website] Improve textarea behaviour (#2464)

hikemaniac notifications at github.com
Wed Dec 18 19:31:05 UTC 2019


hikemaniac commented on this pull request.



> @@ -2092,6 +2092,7 @@ textarea {
   color: #222;
   background-color: #fff;
   border: 1px solid $grey;
+  border-radius: 3px;

I was initially reluctant to use the variable, because it is only used for the navigation bar buttons in the CSS. All the other items that make use of `border-radius` instead have the 3px hardcoded. I thought that `$border-radius` is only used for navigation buttons and if their border-radius is changed in the future, it might look weird if suddenly all sorts of things (e.g. the browse tag list) also have a larger `border-radius`. Should I change it anyway?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2464#discussion_r359528928
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191218/a2010fb7/attachment-0001.html>


More information about the rails-dev mailing list