[openstreetmap/openstreetmap-website] Add links to the ToU and include them in signup (#2028)

[Simon Poole]

> 
> 
> So looking at the UI this present I have to say I find it very confusing... This is what the terms page now looks like:
> 
> ![screenshot_2019-01-30 contributor terms openstreetmap](https://user-images.githubusercontent.com/147741/52004965-6d71b500-24c0-11e9-9419-0f06c85b363b.png)
> 
> So I have a checkbox to say I accept the ToU and then underneath that we have Agree/Decline buttons, which actually refer to the contributor terms at the top but that's like totally not obvious to me at least.
> 
> I think fundamentally it's just odd to have two agree/disagree questions which are answered in different ways - one by checking a box and one by choosing which submit button to press?

In principle I agree, our professionals (lawyers) would have liked to have the text displayed plus a checkbox, and this is the compromise. 

It would perhaps be less confusing to actually have a 2nd (well 1st) check box for the contributor terms, and use a different text for the "Agree" button, "Continue" (and relabel the Decline button too, which we should do in any case as accepting the ToU is mandatory for everybody that gets shown the term screen now, so for the 1-2 people per year from pre-licence change and actually click decline, that option won't do anything reasonable any more).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2028#issuecomment-459075876
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190130/ecf7f20b/attachment.html>