[openstreetmap/openstreetmap-website] Add links to the ToU and include them in signup (#2028)

[Tom Hughes]

tomhughes requested changes on this pull request.

So looking at the UI this present I have to say I find it very confusing... This is what the terms page now looks like:

![screenshot_2019-01-30 contributor terms openstreetmap](https://user-images.githubusercontent.com/147741/52004965-6d71b500-24c0-11e9-9419-0f06c85b363b.png)

So I have a checkbox to say I accept the ToU and then underneath that we have Agree/Decline buttons, which actually refer to the contributor terms at the top but that's like totally not obvious to me at least.

I think fundamentally it's just odd to have two agree/disagree questions which are answered in different ways - one by checking a box and one by choosing which submit button to press?

> @@ -41,7 +41,7 @@ def terms
   def save
     @title = t "users.new.title"
 
-    if params[:decline]
+    if params[:decline] || !params[:read_tou] || params[:read_tou] == "0"

You don't actually need both tests here as "truthiness" means that `"0"` is false and hence the first test will be true...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2028#pullrequestreview-198245960
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190130/736bc8bd/attachment.html>