Re: [openstreetmap/openstreetmap-website] [WIP] XML generation: nodes, ways, relations, map controller → view (#2223)

Andy Allan notifications at github.com
Thu Jun 27 07:42:14 UTC 2019


> I think there's need for .empty? guards when using

Sorry, that should have read 'I think there's **no** need for' the guards.



> The reason why this is outside of `xml.node(attrs) do |nd|` is that it fails horribly otherwise - either producing invalid XML or simply crashing, I don't recall at the moment.

Oh, then perhaps there is. That's a pity since I would have thought the `each` simply doesn't do anything when there's no tags.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2223#issuecomment-506232062
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190627/ab566aea/attachment.html>


More information about the rails-dev mailing list