Re: [openstreetmap/openstreetmap-website] [WIP] XML generation: nodes, ways, relations, map controller → view (#2223)

Tom Hughes notifications at github.com
Thu Jun 27 07:52:12 UTC 2019


> > The reason why this is outside of `xml.node(attrs) do |nd|` is that it fails horribly otherwise - either producing invalid XML or simply crashing, I don't recall at the moment.
> 
> Oh, then perhaps there is. That's a pity since I would have thought the `each` simply doesn't do anything when there's no tags.

I just tried removing the `empty?` special case and it seems to work fine for me for nodes with no tags - it would odd if it didn't given that ways and relations aren't special cased like that and they presumably work.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2223#issuecomment-506235318
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20190627/b69e83c7/attachment.html>


More information about the rails-dev mailing list