[openstreetmap/openstreetmap-website] Add microcosms to the website (#2390)

Brian DeRocher notifications at github.com
Tue Oct 15 13:29:59 UTC 2019


openbrian commented on this pull request.

> @tomhughes I had to make 1 change to a migration in order to get my database up and running. I have not committed it. 20190518115041_add_acl_indexes.rb

And now I see a similar hack in .travis.yml.

> @@ -0,0 +1,21 @@
+MIGRATION_CLASS =
+  if ActiveRecord::VERSION::MAJOR >= 5
+    ActiveRecord::Migration["#{ActiveRecord::VERSION::MAJOR}.#{ActiveRecord::VERSION::MINOR}"]
+  else
+    ActiveRecord::Migration
+  end

autogenerated, maybe from "rails generate friendly_id"

> @@ -0,0 +1 @@
+/home/brian/Workshop/Projects/Microcosm/website/Design.md

It's right here in front of me :)  Sorry, I forgot this file was a symlink.  It's only for dev anyway.  I'll remove it before any merge.

> @@ -0,0 +1 @@
+/home/brian/Workshop/Projects/Microcosm/website/Design.md

Fixed.

> @@ -0,0 +1,21 @@
+MIGRATION_CLASS =
+  if ActiveRecord::VERSION::MAJOR >= 5
+    ActiveRecord::Migration["#{ActiveRecord::VERSION::MAJOR}.#{ActiveRecord::VERSION::MINOR}"]
+  else
+    ActiveRecord::Migration
+  end

fixed

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2390#pullrequestreview-301058518
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20191015/9d61f38e/attachment.html>


More information about the rails-dev mailing list