[openstreetmap/openstreetmap-website] WIP: Convert database config to support reading from replicas (#2563)

Andy Allan notifications at github.com
Wed Apr 8 17:23:01 UTC 2020


> Converting `controller` tests to `system` tests would be welcome, but it's a giant project!

Further investigation shows that there's a middle ground option - updating our controller tests to inherit from `ActionDispatch::IntegrationTest` instead of `ActionController::TestCase` will also work. This is anyway recommended by the rails guide for controller tests (not just integration tests) and also [the documentation for `ActionController::TestCase`](https://api.rubyonrails.org/v6.0.2.2/classes/ActionController/TestCase.html).

It would involve a bunch of refactoring of the tests, but is much less work than rewriting them into system tests, even though system tests are the long term goal.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2563#issuecomment-611086270
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200408/f152534b/attachment.htm>


More information about the rails-dev mailing list