[openstreetmap/openstreetmap-website] Add Docker Compose Support for Development Environment (#2409)

Tobias notifications at github.com
Mon Dec 28 18:33:07 UTC 2020


@tordans commented on this pull request.



> +      uses: actions/checkout at v1
+    - name: Poke config
+      run: |
+        cp config/example.storage.yml config/storage.yml
+        cp config/docker.database.yml config/database.yml
+        touch config/settings.local.yml
+    - name: Build Docker Image
+      run: |
+        docker-compose build
+    - name: Start Docker-Compose
+      run: |
+        docker-compose up -d
+        sleep 15 # let the DB warm up a little
+    - name: Prepare Database
+      run: |
+        docker-compose run --rm web rake db:migrate

```suggestion
        docker-compose run --rm web rails db:migrate
```

Since we are on a fairly new version of Rails, this is the same and looks a bit nicer and is more up to date. 

(I will comment only this one random instance, but there are a few of them)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2409#pullrequestreview-559256980
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201228/1bdc759b/attachment.htm>


More information about the rails-dev mailing list