[openstreetmap/openstreetmap-website] Add microcosms to the website (#2390)
notifications at github.com
Sat Feb 1 12:27:49 UTC 2020
> So I hope you feel I'm not just going to up and leave.
That's not my main concern - my main worry is that if this PR continues to diverge from upstream, neither of us will find it particularly enjoyable to spend months refactoring it! For example, every time you write a cucumber test, I see something that will need to be rewritten before it can be reviewed. Same with the other topics that I mention. So it's less work all round if we sort things like that out sooner rather than later. That's what I mean by heading towards a merge-able state.
I'll talk more about cucumber specifically in a separate issue, so that we don't swamp this one.
I can open a ticket to ask for your branch to be deployed on apis.dev.osm.org
With styles, we now have Bootstrap available and the need for custom styles for any particular page will be greatly reduced. I would aim for you having no custom CSS at all, and instead picking components and utilities from the list available at https://getbootstrap.com/docs/4.4/getting-started/introduction/ and otherwise letting bootstrap do the styling by default. The current common.css file is a mess and most of it is disappearing as I continue refactoring the site, so it's best ignored.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev