[openstreetmap/openstreetmap-website] Add microcosms to the website (#2390)
notifications at github.com
Mon Feb 3 13:49:29 UTC 2020
@gravitystorm I'm following up on the change to replace geckodriver in .travis.yml with using the titusfortner/webdrivers gem. Somehow it works locally (yes, I've taken geckodriver out my $PATH). But tests fail on travis because webmock is preventing the download of the webdrivers.
I looked back in the git history to see where webmock was introduced and why. Seems to be used in test_helper.rb in with_http_stubs(). So instead of calling out to geonames, geocoder_ca, and nominatim, we just return data from disk.
The policy to disable network connection (except for localhost) is also in test_helper.rb line 24.
Looks like webmock allows a whitelist of allowed sites. https://www.rubydoc.info/gems/webmock/2.0.2#External_requests_can_be_disabled_while_allowing_specific_requests I would add for example https://chromedriver.storage.googleapis.com
Do you suggest doing that?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the rails-dev