[openstreetmap/openstreetmap-website] fix welcome message (#2537)

Anton notifications at github.com
Thu Feb 27 09:41:31 UTC 2020


bezdna commented on this pull request.



> @@ -40,8 +40,12 @@
 
     <% unless current_user %>
       <div class="welcome">
-        <h2><%= t "layouts.intro_header" %></h2>
-        <div class="close-wrap"><span class="icon close"></span></div>
+        <div class="welcome-header">
+          <h2><%= t "layouts.intro_header" %></h2>
+          <button type="button" class="button close" aria-label="Close">
+            <span class="icon close"></span>
+          </button>
+        </div>

1. In terms of semantics, a button is not a title element
2. in terms of accessibility, if the button is in a block with a heading, this implies that the button will close the heading, not the block.
3. from the layout point of view, managing floats in RTL and LTR is more difficult, and this should be monitored.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2537#discussion_r385011790
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200227/7db8749c/attachment.htm>


More information about the rails-dev mailing list