[openstreetmap/openstreetmap-website] Use a post link to logout (#2496)

[Tom Hughes]

tomhughes commented on this pull request.



> @@ -344,27 +344,13 @@ def test_save_referer_params
   end
 
   def test_logout_without_referer
-    get :logout
-    assert_response :success
-    assert_template :logout
-    assert_select "input[name=referer][value=?]", ""
-
-    session_id = assert_select("input[name=session]").first["value"]
-
-    get :logout, :params => { :session => session_id }

I'm inclined to leave in the get test in method which checks that GET returns the login page - obviously get rid of the assertion that the session ID is in the returned form.

I know you're doing it in the system tests as well, but the cases here do check extra things like that the fallback page preserves the referer?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2496#pullrequestreview-339863513
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200108/0d0c8394/attachment.htm>