[openstreetmap/openstreetmap-website] JSON output nodes, ways, relations, map (#2485)

mmd notifications at github.com
Wed Jan 22 15:16:12 UTC 2020


mmd-osm commented on this pull request.

>  I think the set_default_request_format would be better applied to every api method, but you only have it for a few (e.g. before_action :set_default_request_format, :except => [:create, :update, :delete]). Can you talk more about that?

Yes, that's also intentional. On the one hand, I only wanted to include those methods for which we have some test coverage. On the other hand, some of those methods return plain text, rather than XML. I felt like overriding request.format could potentially introduce some havor in the future, so I deliberately excluded those methods which are not in scope right now.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2485#pullrequestreview-346666226
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200122/03593151/attachment.htm>


More information about the rails-dev mailing list