[openstreetmap/openstreetmap-website] WIP: Bootstrap form (#2667)

Tom Hughes notifications at github.com
Wed Jun 24 16:59:50 UTC 2020


@tomhughes commented on this pull request.



> @@ -1,7 +1,9 @@
 {
   "name": "openstreetmap",
   "private": true,
-  "dependencies": {},
+  "dependencies": {
+    "bs-custom-file-input": "^1.3.4"
+  },

We haven't been using yarn to manage javascript for the actual web site to date, although I have experimented with it. I was slightly surprised it worked but I see `node_modules` has crept on to the include path at some point, and the other infrastructure change I made for it has also been made for other reasons.

I guess there's no reason not to do it, other than trying to keep everything in one place - although is other stuff we could manage via yarn there are some things where we can't at the moment so would have to stick with vendorer.

It does mean that we will need to run yarn as part of the deployment though and to date we don't have any tooling for that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2667#pullrequestreview-436837197
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200624/59bfd3b3/attachment-0001.htm>


More information about the rails-dev mailing list