[openstreetmap/openstreetmap-website] Enable minitest test name cop (#2918)

[Andy Allan]

This PR includes a small refactoring, and marking many utility methods in the test suite as `private`, in order that we can enable the `Minitest/TestMethodName` cop.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/2918

-- Commit Summary --

  * Refactor test to use general basic_authorization_header method
  * Ensure that test utility methods are marked as private

-- File Changes --

    M .rubocop_todo.yml (15)
    M test/abilities/api_capability_test.rb (2)
    M test/controllers/api/nodes_controller_test.rb (2)
    M test/controllers/api/old_nodes_controller_test.rb (14)
    M test/controllers/api/relations_controller_test.rb (42)
    M test/controllers/api/ways_controller_test.rb (2)
    M test/helpers/browse_helper_test.rb (4)
    M test/integration/client_applications_test.rb (2)
    M test/integration/short_links_test.rb (2)
    M test/integration/user_blocks_test.rb (12)
    M test/integration/user_creation_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/2918.patch
https://github.com/openstreetmap/openstreetmap-website/pull/2918.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/2918
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20201028/b7d0d991/attachment.htm>