[openstreetmap/openstreetmap-website] Allow the hiding of changeset tags (#1167)
Andy Allan
notifications at github.com
Wed Sep 30 14:06:06 UTC 2020
I've reviewed this PR again today, and for a few reasons, I don't think it's yet suitable for merging:
* There's no tests included.
* There should be consistency between what's available through the website and through the API.
* The permissions checks should be done via the abilities system, rather than hardcoded roles.
* Redaction vs simple hiding of data needs to be decided, and work through the implications for dumps.
The first two should be fairly straightforward to fix, so I'd be happy to see a fresh PR with the above items addressed. For the fourth one, it might be worth discussing in an issue before coding.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/1167#issuecomment-701413445
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20200930/972b8b17/attachment.htm>
More information about the rails-dev
mailing list