[openstreetmap/openstreetmap-website] Display message when the there are no notes/comments to display (#3169)

Andy Allan notifications at github.com
Wed Apr 28 09:36:13 UTC 2021


@gravitystorm commented on this pull request.



> @@ -73,4 +73,11 @@ def test_index_paged
     assert_response :success
     assert_select "table.note_list tr", :count => 11
   end
+
+  def test_empty_page

I'm happy with smaller tests. 

I also agree with you with the rspec topic - I use it on all my other projects, and I much prefer having the context blocks with individual tests, rather than ending up with our normal mega-test that are dozens of assertions and 'paragraphs' long. But I'm not sure if there's much appetite for rewriting the test suite yet, until we have a few more developers at least!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3169#discussion_r622002140
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210428/55cbfc12/attachment.htm>


More information about the rails-dev mailing list