[openstreetmap/openstreetmap-website] Add Communities page (#3301)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -106,6 +106,11 @@ def about
     @locale = params[:about_locale] || I18n.locale
   end
 
+  def communities
+    @locale = params[:communities_locale] || I18n.locale

If it's just a about translation why are you allowing the language to be overridden? You should just use `I18n.locale` if that's what you're trying to do.

The only page where we allow overriding like this is the copyright page, for legal reasons to do with being able to switch between english and the localised form.

A more general ability to override the language is a much requested feature but it should be done system wide not on a per page basis like this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3301#discussion_r696122545
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210825/65b33944/attachment-0001.htm>