[openstreetmap/openstreetmap-website] Separate forms for preferences and profile (#3257)

[Andy Allan]

This forms the first part of implementing #3167 , by creating separate forms for preferences and for changing your profile information. 

This helps make the users#account form (and update logic) simpler, although it's still very complex. The preferences page is currently a bit sparse, but could be expanded as we add more things to the site, and could be improved by much better descriptions of how the language preferences are supposed to work! Again, these can be follow-on tasks.


You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3257

-- Commit Summary --

  * Split user preferences into a separate page
  * Remove code complexity around resetting language preferences
  * Move profile-related settings to their own form

-- File Changes --

    M app/abilities/ability.rb (2)
    M app/controllers/application_controller.rb (7)
    M app/controllers/confirmations_controller.rb (4)
    A app/controllers/preferences_controller.rb (32)
    A app/controllers/profiles_controller.rb (43)
    M app/controllers/users_controller.rb (30)
    M app/models/user.rb (5)
    M app/views/layouts/_header.html.erb (1)
    A app/views/preferences/edit.html.erb (12)
    A app/views/preferences/show.html.erb (28)
    A app/views/profiles/edit.html.erb (61)
    M app/views/users/account.html.erb (51)
    M app/views/users/show.html.erb (6)
    M config/locales/en.yml (53)
    M config/routes.rb (3)
    A test/controllers/preferences_controller_test.rb (56)
    A test/controllers/profiles_controller_test.rb (67)
    M test/controllers/users_controller_test.rb (74)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3257.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3257.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3257
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210714/daed0953/attachment.htm>