[openstreetmap/openstreetmap-website] Separate forms for preferences and profile (#3257)

[Tom Hughes]

@tomhughes commented on this pull request.



> +
+<dl class="row">
+  <dt class="col-sm-4"><%= t ".preferred_editor" %></dt>
+
+  <% if current_user.preferred_editor? %>
+    <dd class="col-sm-8"><%= t("editor.#{current_user.preferred_editor}.description") %></dd>
+  <% else %>
+    <dd class="col-sm-8"><%= t("editor.default", :name => t("editor.#{Settings.default_editor}.name")) %></dd>
+  <% end %>
+
+  <dt class="col-sm-4"><%= t ".preferred_languages" %></dt>
+
+  <dd class="col-sm-8">
+    <ul>
+      <% current_user.preferred_languages.each do |locale| %>
+        <li><%= locale %></li>

I thought I had mentioned this in my previous review but apparently I missed it...

I don't know about you but I'm not particularly keen on the bulleted list here... What do you think to just a simple list? (I did `list-style: none; padding-left: 0` to test it)

> @@ -1644,6 +1644,42 @@ en:
       reset: "Reset Password"
       flash changed: "Your password has been changed."
       flash token bad: "Did not find that token, check the URL maybe?"
+  preferences:
+    show:
+      title: My Preferences

This, and the other titles are in title case but I think we generally only capitalise the first word of page titles? Though I'm not sure I don't prefer it this way...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3257#pullrequestreview-711989032
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210721/7580ef2b/attachment.htm>