[openstreetmap/openstreetmap-website] Create a SessionsController (#3147)

[Andy Allan]

> Presumably at some point thing like the omniauth callbacks that use those shared routines should themselves move to the session controller given they are concerned with creating sessions?

I took that approach during development, but I didn't like it, since the Devise::SessionsController doesn't have any omniauth things in it. However, there is an [omniauth callbacks controller](https://github.com/heartcombo/devise/blob/master/app/controllers/devise/omniauth_callbacks_controller.rb) for devise - I haven't checked yet, but they might go in there, but I really don't know much about omniauth yet so I'm not sure if they are doing the same thing.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3147#issuecomment-805845649
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210324/9e04b4bd/attachment-0001.htm>