[openstreetmap/openstreetmap-website] Reduce usage of margin-top for layout (PR #3362)

[Andy Allan]

This PR reduces the usage of margin-top for controlling layouts. Bootstrap [tries to avoid margin-top](https://getbootstrap.com/docs/4.0/content/reboot/) since they collapse into preceding margin-bottoms, so it's easier to be consistent and just use margin-bottoms instead. Since they are applied to most elements (like tables, lists, paragraphs) by default, some refactoring of plain text-in-div to text-in-paragraph solved the spacing problems, otherwise I used the bootstrap margin utilities.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3362

-- Commit Summary --

  * <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/2b84452222db25cfcfdc2a788ebea79d2ea517f7">Remove custom margins on sidebar headings</a>
  * <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/826a864e6c3e1f733b74d6d5aacf6b3253507a75">Remove the contact-activity class</a>
  * <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/6bce75b134a1175359360c5e3ee17bb8edfeb6f0">Add button classes for users list action buttons</a>
  * <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/ea0f128e9e5d5f42e41adc44e1fa6cd45f608bcb">Remove the paragraph margin overrides for the users list</a>
  * <a href="https://github.com/openstreetmap/openstreetmap-website/pull/3362/commits/abe855150656ca2fdb7d786716b3c14bea164265">Remove custom css overrides for the users list</a>

-- File Changes --

    M app/assets/stylesheets/common.scss (29)
    M app/views/browse/_common_details.html.erb (4)
    M app/views/browse/changeset.html.erb (14)
    M app/views/dashboards/_contact.html.erb (2)
    M app/views/dashboards/show.html.erb (4)
    M app/views/users/index.html.erb (6)
    M test/controllers/dashboards_controller_test.rb (4)
    M test/integration/user_changeset_comments_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3362.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3362.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3362
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20211110/dc8f8b41/attachment.htm>