[openstreetmap/openstreetmap-website] Add Communities page (#3301)

Adam Hoyle notifications at github.com
Wed Sep 8 19:57:50 UTC 2021


@tomhughes apologies for the delay getting back to this - I've refactored the data stuff in a way that I _think_ is an improvement. At any rate I'm a bit less embarrassed by it now. I'm not sure if `lib` is the right place to put these, but it seems better than `models`. 

I'm still not really sure how to add tests to it, considering how dependent it is on the npm lib / data files, but I'll take a look at the tests that exist already and see if I can find any similar patterns to be inspired by.

Anyway I'd love to get any / all feedback you have (and that applies to anyone else reading this too 👋 )

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3301#issuecomment-915528108
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20210908/568b5b32/attachment.htm>


More information about the rails-dev mailing list