[openstreetmap/openstreetmap-website] Remember loaded changesets and scroll position in user edit history (PR #3682)
mmd
notifications at github.com
Sun Dec 4 19:04:49 UTC 2022
I tested this on Firefox:
* I pressed "Load more" a few times
* clicked on a changeset further down in the list, and
* pressed the back button to return to the list of changesets.
result: previous state was restored.
However, in some cases, when I click on the very first entry in the list of changesets, and then hit the back button, the previous state is lost somehow, and I only see the very first page of changesets. I cannot reliably reproduce the issue, it might be some timing issue.
Storing all the data as HTML fragments feels a bit heavy to me. As a browser only solution, you're a bit limited in what you can do client side (Rails returns the data as rendered HTML only.) At least you have added a max entry limit of 10 lat/lon keys to avoid accumulating too much data.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3682#issuecomment-1336492870
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3682/c1336492870 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221204/491f3eeb/attachment.htm>
More information about the rails-dev
mailing list