[openstreetmap/openstreetmap-website] Add inverse_of to relationships that can't detect it automatically (PR #3472)
Tom Hughes
notifications at github.com
Wed Feb 23 19:26:54 UTC 2022
This partially addresses #3471 by adding `:inverse_of` to as many relationships that need it as we can easily do.
There are some which either don't have an inverse relationship, or which are conditional so that the inverse is not really an exact inverse, or where (like doorkeeper) we don't actually control the class on the other end.
The cop is now enabled, but with exceptions for files which still have issues to be resolved.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3472
-- Commit Summary --
* Add inverse_of to relationships that can't detect it automatically
-- File Changes --
M .rubocop.yml (3)
M .rubocop_todo.yml (33)
M app/models/diary_entry.rb (4)
M app/models/language.rb (2)
M app/models/node.rb (2)
M app/models/note.rb (2)
M app/models/old_node.rb (4)
M app/models/old_node_tag.rb (2)
M app/models/old_relation.rb (6)
M app/models/old_relation_member.rb (2)
M app/models/old_relation_tag.rb (2)
M app/models/old_way.rb (6)
M app/models/old_way_node.rb (2)
M app/models/old_way_tag.rb (2)
M app/models/relation.rb (4)
M app/models/trace.rb (4)
M app/models/tracepoint.rb (2)
M app/models/tracetag.rb (2)
M app/models/user.rb (18)
M app/models/way.rb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3472.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3472.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3472
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3472 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220223/5daa9720/attachment-0001.htm>
More information about the rails-dev
mailing list