[openstreetmap/openstreetmap-website] Use a state machine for user status (PR #3419)

[Tom Hughes]

@tomhughes commented on this pull request.



> +    # Used in test suite, not something that we would normally need to do.
+    event :deactivate do
+      transitions :from => :active, :to => :pending
+    end

Well if it was only used for test cases then we should just remove those test cases as by definition we would be testing functionality that wasn't used in real life - that's better than polluting the source with comments.

As I said in my review though currently there is a production use case, it's just that this PR currently removes the ability to use it. There's probably no need for it though, if I was able to move people from suspended/confirmed to active though.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3419#discussion_r783722174
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3419/review/851376396 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220113/2951d911/attachment.htm>