[openstreetmap/openstreetmap-website] Arrange base layers menu in a grid (PR #3620)

[Anton Khorev]

> I'm not going to argue the merits of one grid system against another - I'm not an expert in either! 

I'm not arguing about merits of grid system. I'm arguing about [explicitly specified grids vs implicitly specified ones](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout#the_implicit_and_explicit_grid). Let's say you have a commenting UI where you have a textarea and on the left side and a box with kramdown hints on the right side. You want textarea on the left and kramdown hints on the right. Therefore you declare that there's a row with two columns, the left column contains the textarea and the right one contains the hints.

Now you have a set of layer switching buttons. You *don't care which rows and columns they occupy*. Why would you go and write out those rows and columns if you don't care about them?

> I'll note that bootstrap 5 has experimental support for CSS grids, that's disabled by default. Maybe that will become default in the future or we'll switch to it or something, I have no idea.

You mean this thing?
https://getbootstrap.com/docs/5.1/layout/css-grid/

You still have to declare rows and columns manually with it, right? That's still an *explicit* grid. The reason to do the grid differently for layer buttons is because it's an *implicit* grid.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3620#issuecomment-1195535079
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3620/c1195535079 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220726/791e2060/attachment.htm>