[openstreetmap/openstreetmap-website] Arrange base layers menu in a grid (PR #3620)

[Anton Khorev]

> @AntonKhorev to be honest, it pains me to read the last few messages.

Let's clear this up. Are you telling that I should have used an explicit grid for layer buttons?

> Andy gave a clear guidance on how he thinks the code should be structured.

In case you think that I should have used implicit grid:
A clear guidance would be telling me how to do implicit grids in Bootstrap. I'm not a Bootstrap expert and I don't know how to do it. I searched for the relevant css properties in bootstrap source code and found nothing: https://github.com/twbs/bootstrap/search?q=grid-template , at least in the current version. Maybe there's some plugin?

In case you think that explicit grid is better: why? Is it just about not using any css features that are not defined in Bootstrap? And why is that? For maintenance because the code will get more complicated otherwise? My proposed change here adds three css properties and removes one. You hardly can do this change any simpler than that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3620#issuecomment-1195575593
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3620/c1195575593 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220726/b18bfa81/attachment.htm>