[openstreetmap/openstreetmap-website] WIP: search forms redesign (PR #3400)

Andy Allan notifications at github.com
Wed Mar 2 18:09:18 UTC 2022


Thanks for the mockup. I didn't realise until reviewing that it's a mockup rather than a proposal (i.e. there's a hardcoded options list, none of the buttons work) so I've converted this to a draft.

I think this highlights that we need to change the secondary button colour, since it's quite a dark shade of grey compared to our blue and green colours.

I don't think primary is the correct choice for the type-of-route buttons, since that's not actually an action on the form, rather it's a toggle choice. I would like to keep the primary colour for the main action (i.e. "click here to make something happen now").

* Talking of which, there's no button to make the routing happen now. Is that deliberate?
* How do you propose to handle situations where there are either more or fewer types of routing available? Different engines might have different lists of options (e.g. off-road cycling, skating, only car etc).
* Where do the icons come from? There's no attribution afaict. 
* The icons seem a bit inconsistent e.g. the weight of the arrows compared to the weight of the cross symbol. Do they all come from the same icon set?

(For icon sets, perhaps https://icons.getbootstrap.com/ would be useful.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3400#issuecomment-1057225749
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3400/c1057225749 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220302/56d675dc/attachment.htm>


More information about the rails-dev mailing list