[openstreetmap/openstreetmap-website] WIP: search forms redesign (PR #3400)
mjourdan
notifications at github.com
Wed Mar 2 20:40:13 UTC 2022
Yes, this was meant as a prototype rather than a fully fledged implementation. Thanks for taking a look at it.
> Talking of which, there's no button to make the routing happen now. Is that deliberate?
Yes, filling in the two fields and pressing enter should be sufficient to get the results
> How do you propose to handle situations where there are either more or fewer types of routing available? Different engines might have different lists of options (e.g. off-road cycling, skating, only car etc).
The options would be updated according to the selected engine.
> Where do the icons come from? There's no attribution afaict.
> The icons seem a bit inconsistent e.g. the weight of the arrows compared to the weight of the cross symbol. Do they all come from the same icon set?
It's true they are inconsistent. Arrows come from bootstrap, but I had to get the others from elsewere (ie gnome), as [evocated here](https://github.com/openstreetmap/openstreetmap-website/issues/3123#issuecomment-803141517).
Here is a small update after switchingfrom btn-primary to btn-light:

--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3400#issuecomment-1057356900
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3400/c1057356900 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220302/a72cf2f0/attachment.htm>
More information about the rails-dev
mailing list