[openstreetmap/openstreetmap-website] OAuth updates to CONFIGURE doc + cosmetic tweak (PR #3492)

Andy Allan notifications at github.com
Tue Mar 8 14:24:07 UTC 2022


@gravitystorm requested changes on this pull request.

Just a couple of small layout/css tweaks, but otherwise looks good to me.

> @@ -34,10 +34,14 @@
 <p><%= t(".no_apps_html", :oauth => link_to(t(".oauth"), "https://oauth.net")) %></p>
 <% else %>
 <p><%= t ".registered_apps" %></p>
-<% @client_applications.each do |client| %>
-  <div class="client_application">
-    <%= link_to client.name, :action => :show, :id => client.id %>
-  </div>
-<% end %>
+<p>

Should be a list (which has automatic bottom padding) rather than wrapping in a paragraph

>  <% end %>
-<h3><%= link_to t(".register_new"), :action => :new %></h3>
+<p>

No need to wrap a button in a paragraph tag (and it's not really correct anyway, since the contents aren't a paragraph of text). 

The final button on the page doesn't need any bottom padding anyway.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3492#pullrequestreview-903080077
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3492/review/903080077 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220308/03d304a3/attachment.htm>


More information about the rails-dev mailing list