[openstreetmap/openstreetmap-website] Hide changesets from history list that don't fit into view (PR #3417)

[Tom Hughes]

@tomhughes requested changes on this pull request.

I think the main operational question here is, what is the performance impact of this likely to be - basically how many additional changesets may the database have to consider to try and find ones which fit in the view?

> @@ -78,18 +78,35 @@ def feed
   # utility functions below.
   #------------------------------------------------------------
 
+  ##
+  # The API has few situations, where parameter is supposed
+  # to have boolean value (true/false), but previously their
+  # values were ignored and script checked only null/not null
+  # state.
+  # If string value is true, return boolean true, otherwize false.
+  def check_boolean(value)

If this is needed by multiple controllers then it should be moved up to `application_controller.rb` instead of duplicating it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3417#pullrequestreview-904141384
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3417/review/904141384 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20220309/8ff49163/attachment.htm>