[openstreetmap/openstreetmap-website] Enable the Action Order cop for remaining controllers (PR #3781)

[Andy Allan]

Where actions were reordered, the rails standard actions were also moved to the top of each controller.

My personal preference is for index/new/create/edit/update/destroy (i.e. pair off new/create and edit/update) but I guess it's better to follow the default order, which is based on the rails scaffolding order too.

I would be delighted at some point if we get to the point of having *only* these actions, but that's work for another day. :smiley: 

I've also fixed a comment (by deleting most of it) that I noticed while reordering actions - it referred to the old approach of having multi-purpose actions which was refactored a while ago.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3781

-- Commit Summary --

  * Enable the ActionOrder cop for remaining controllers
  * Remove outdated comments

-- File Changes --

    M .rubocop_todo.yml (21)
    M app/controllers/api/changesets_controller.rb (28)
    M app/controllers/api/nodes_controller.rb (48)
    M app/controllers/api/notes_controller.rb (100)
    M app/controllers/api/relations_controller.rb (44)
    M app/controllers/api/traces_controller.rb (58)
    M app/controllers/api/users_controller.rb (32)
    M app/controllers/api/ways_controller.rb (44)
    M app/controllers/diary_entries_controller.rb (144)
    M app/controllers/messages_controller.rb (73)
    M app/controllers/oauth_clients_controller.rb (28)
    M app/controllers/redactions_controller.rb (8)
    M app/controllers/traces_controller.rb (80)
    M app/controllers/users_controller.rb (206)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3781.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3781.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3781
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3781 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221102/40ac53aa/attachment.htm>