[openstreetmap/openstreetmap-website] Group map controls explicitly (PR #3704)
Andy Allan
notifications at github.com
Wed Oct 19 14:52:13 UTC 2022
Thanks for the PR, and thanks for your patience too.
A couple of things that I thought of while reviewing this PR:
* I don't know if there's any way to avoid specifying the classes for the first and last item in the group? Bootstrap button groups work (somehow, I haven't investigated) just based on the position of the button in the button group
* The rounding would be even better if we used the SASS variables from bootstrap - e.g. `border-start-start-radius: $border-radius;` so that they match the rest of the site automatically (although given the small sizes, it's not currently noticeable
* The rounding would be even better than that, if we could use bootstrap classes to control the rounding (so that if e.g. we have responsive rounding radii, it works automatically). But I can't find any description of how to round only one corner with the bootstrap docs, so maybe that's not possible.
Thanks again!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3704#issuecomment-1284143355
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3704/c1284143355 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221019/58bf955b/attachment.htm>
More information about the rails-dev
mailing list