[openstreetmap/openstreetmap-website] Group map controls explicitly (PR #3704)

[Anton Khorev]

> I don't know if there's any way to avoid specifying the classes for the first and last item in the group? Bootstrap button groups work (somehow, I haven't investigated) just based on the position of the button in the button group

Look at css in the intermediate commits, particularly this one: https://github.com/openstreetmap/openstreetmap-website/pull/3704/commits/7904b49bb13c23b8c8beb4f5bcf25fa12d8374dd . I decided that if I keep it that's going to be too much custom css. And that's not very obvious css with selector combinators.

> The rounding would be even better if we used the SASS variables from bootstrap - e.g. `border-start-start-radius: $border-radius;` so that they match the rest of the site automatically (although given the small sizes, it's not currently noticeable

The rounding was set in pixels before I made any changes here. It's in pixels probably because the button sizes are in pixels. And they are in pixels probably because they have raster icons.

> The rounding would be even better than that, if we could use bootstrap classes to control the rounding (so that if e.g. we have responsive rounding radii, it works automatically). But I can't find any description of how to round only one corner with the bootstrap docs, so maybe that's not possible.

I managed to round two, three or four corners with bootstrap classes but not one. And what sort of responsive radii do you want if icons are of fixed sizes?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3704#issuecomment-1285127031
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3704/c1285127031 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221020/73f26ca5/attachment-0001.htm>