[openstreetmap/openstreetmap-website] Merge changeset <ol>s on Load more (PR #3769)
Anton Khorev
notifications at github.com
Wed Oct 26 12:28:17 UTC 2022
Since the pull request https://github.com/openstreetmap/openstreetmap-website/pull/3682 is not going anywhere I'll start taking it apart. Here are the changes in https://github.com/openstreetmap/openstreetmap-website/pull/3682/commits/10319cac0d54ddb9e8f1f467cf16928646474730.
On any history page that displays a list of changesets the "Load more" button loads more changesets. This button creates another list element for those changesets. You get as many lists as the number of times you pressed the button plus the original list. There's a line between list items but no line between lists. To the user it looks like some dividing lines are missing. Here you can see that there's no line between the second and the third changesets:

This PR makes "Load more" to merge the changesets it loads into the original html list so there's only one list.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/3769
-- Commit Summary --
* Merge changeset <ol>s on Load more
-- File Changes --
M app/assets/javascripts/index/history.js (18)
M test/system/history_test.rb (43)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/3769.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3769.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3769
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/3769 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221026/63f01dec/attachment.htm>
More information about the rails-dev
mailing list