[openstreetmap/openstreetmap-website] Use close button instead of geolink in sidebar content (PR #3770)

[Anton Khorev]

This is https://github.com/openstreetmap/openstreetmap-website/pull/3682/commits/cc9bcce5f0531243c34ffab8d43bc2885ff106ef + https://github.com/openstreetmap/openstreetmap-website/pull/3682/commits/b9f05806dbda4c33fcad5c1d68cb59623c432989

When I was changing close buttons to Bootstrap's `class="btn-close"`, I kept the one in the left sidebar as a link. It was a "geolink" and I didn't want to remove it because "geolinks" are updated when map view changes and I didn't know exactly how it was happening. Later in https://github.com/openstreetmap/openstreetmap-website/pull/3682 I finally replaced it with a button. I think I did it so I could cache the entire sidebar without worrying about map view updates.

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3770

-- Commit Summary --

  * Use close button instead of geolink in sidebar content

-- File Changes --

    M app/assets/javascripts/index.js (4)
    M app/views/application/_sidebar_header.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3770.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3770.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3770
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3770 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20221026/8f4b05c0/attachment.htm>